Skip to content

Commit

Permalink
Stabilize discovery test using standard top level breadcrumb filter (#…
Browse files Browse the repository at this point in the history
…145)

* Stabilize discovery test using standard top level breadcrumb filter

* Move tap-postgres out of tier 1 as tests no longer pass after ubuntu upgrade from 18 to 22

* Pin tap-tester image to ubuntu 18

---------

Co-authored-by: btowles <[email protected]>
  • Loading branch information
bhtowles and bhtowles authored Jun 22, 2023
1 parent e863a4d commit 7d3ef40
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ orbs:
jobs:
build:
docker:
- image: 218546966473.dkr.ecr.us-east-1.amazonaws.com/circle-ci:stitch-tap-tester
- image: 218546966473.dkr.ecr.us-east-1.amazonaws.com/circle-ci:stitch-tap-tester-18.04
- image: singerio/postgres:9.6-wal2json-2.2-ssl
environment:
POSTGRES_USER: postgres
Expand Down Expand Up @@ -49,7 +49,7 @@ workflows:
- build:
context:
- circleci-user
- tier-1-tap-user
- tap-tester-user
build_daily:
<<: *commit_jobs
triggers:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_postgres_discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def discovery_test(self, conn_id):
)
actual_fields_to_datatypes = {
item['breadcrumb'][1]: item['metadata'].get('sql-datatype')
for item in stream_metadata[1:]
for item in stream_metadata if item['breadcrumb'] != []
}

# Verify there is only 1 top level breadcrumb in metadata
Expand Down

0 comments on commit 7d3ef40

Please sign in to comment.