fix: remove EnableDeckSelection feature flag

cmd/2sp/main.go

@@ -43,7 +43,6 @@ func main() {
 		game.WithStateMessagePeriod(config.StateMessagePeriod),
 		game.WithEnableSymmetricEncryption(config.EnableSymmetricEncryption),
 		game.WithClock(clockwork.NewRealClock()),
-		game.WithFeatureDeckSelection(config.FeatureDeckSelection()),
 	}
 
 	game := game.NewGame(options)

internal/config/config.go

@@ -37,7 +37,6 @@ var wakuDiscV5 bool
 var wakuDnsDiscovery bool
 var demo bool
 var version bool
-var featureFlagEnableDeckSelection bool
 
 var Logger *zap.Logger
 var LogFilePath string
@@ -101,7 +100,6 @@ func ParseArguments() {
 	flag.BoolVar(&wakuDnsDiscovery, "waku.dnsdiscovery", true, "Enable DNS discovery")
 	flag.BoolVar(&demo, "demo", false, "Run demo and quit")
 	flag.BoolVar(&version, "version", false, "Print version and quit")
-	flag.BoolVar(&featureFlagEnableDeckSelection, "feature.deck", false, "Enable deck selection feature")
 	flag.Parse()
 
 	initialAction = strings.Join(flag.Args(), " ")
@@ -156,7 +154,3 @@ func Demo() bool {
 }
 
 func Version() bool { return version }
-
-func FeatureDeckSelection() bool {
-	return featureFlagEnableDeckSelection
-}

pkg/game/features.go

@@ -1,13 +1,10 @@
 package game
 
 type FeatureFlags struct {
-	EnableDeckSelection bool
 }
 
 func defaultFeatureFlags() FeatureFlags {
-	return FeatureFlags{
-		EnableDeckSelection: false,
-	}
+	return FeatureFlags{}
 }
 
 type codeControlFlags struct {

pkg/game/game.go

@@ -654,9 +654,6 @@ func (g *Game) hiddenCurrentState() *protocol.State {
 }
 
 func (g *Game) SetDeck(deck protocol.Deck) error {
-	if !g.features.EnableDeckSelection {
-		return errors.New("deck selection is disabled")
-	}
 	if !g.isDealer {
 		return errors.New("only dealer can set deck")
 	}

pkg/game/options.go

@@ -79,9 +79,3 @@ func WithAutoReveal(enabled bool, delay time.Duration) Option {
 		g.config.AutoRevealDelay = delay
 	}
 }
-
-func WithFeatureDeckSelection(enabled bool) Option {
-	return func(g *Game) {
-		g.features.EnableDeckSelection = enabled
-	}
-}

pkg/game/options_test.go

@@ -29,7 +29,6 @@ func TestOptions(t *testing.T) {
 	publishStateLoop := gofakeit.Bool()
 	autoRevealEnabled := gofakeit.Bool()
 	autoRevealDelay := time.Duration(gofakeit.Int64())
-	enableDeckSelection := gofakeit.Bool()
 
 	options := []Option{
 		WithContext(ctx),
@@ -43,7 +42,6 @@ func TestOptions(t *testing.T) {
 		WithStateMessagePeriod(stateMessagePeriod),
 		WithPublishStateLoop(publishStateLoop),
 		WithAutoReveal(autoRevealEnabled, autoRevealDelay),
-		WithFeatureDeckSelection(enableDeckSelection),
 	}
 	game := NewGame(options)
 
@@ -60,7 +58,6 @@ func TestOptions(t *testing.T) {
 	require.Equal(t, publishStateLoop, game.config.PublishStateLoopEnabled)
 	require.Equal(t, autoRevealEnabled, game.config.AutoRevealEnabled)
 	require.Equal(t, autoRevealDelay, game.config.AutoRevealDelay)
-	require.Equal(t, enableDeckSelection, game.features.EnableDeckSelection)
 }
 
 func TestNoTransport(t *testing.T) {