fix: hint for no votes (#66)

pkg/game/hints.go

@@ -29,6 +29,7 @@ const (
 	// Rejection reasons
 	varietyOfVotesIsTooHigh   = "No strong consensus among the players"
 	maximumDeviationIsTooHigh = "Maximum deviation threshold exceeded"
+	notEnoughVotes            = "Nobody voted 🤷‍"
 	// Advices
 	descriptionBingo          = "BINGO! 🎉💃"
 	descriptionGoodJob        = "Good job 😎"
@@ -50,6 +51,14 @@ func GetResultHint(deck protocol.Deck, issueVotes protocol.IssueVotes) (*protoco
 		return nil, err
 	}
 
+	if len(indexes) == 0 {
+		return &protocol.Hint{
+			Acceptable:  false,
+			Value:       "",
+			Description: notEnoughVotes,
+		}, nil
+	}
+
 	// Calculate measures for the votes
 	resultMeasures := getMeasures(indexes)
 	medianValueIndex := resultMeasures.median
@@ -110,6 +119,12 @@ func getMeasures(values []int) hintMeasurements {
 	// median value
 	r.median = median(values)
 
+	if r.median < 0 {
+		r.maxDeviation = 0
+		r.meanDeviation = 0
+		return r
+	}
+
 	// Maximum deviation
 	r.maxDeviation = 0
 	for _, v := range values {

pkg/game/hints_test.go

@@ -112,6 +112,12 @@ func TestHint(t *testing.T) {
 			measurements: hintMeasurements{median: 3, meanDeviation: 1, maxDeviation: 2},
 			expectedHint: protocol.Hint{Acceptable: false, Value: "5", Description: varietyOfVotesIsTooHigh},
 		},
+		{
+			// This also tests round up median when even number of votes
+			values:       []protocol.VoteValue{},
+			measurements: hintMeasurements{median: -1, meanDeviation: 0, maxDeviation: 0},
+			expectedHint: protocol.Hint{Acceptable: false, Value: "", Description: notEnoughVotes},
+		},
 	}
 
 	for _, tc := range testCases {