Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: 移除不必要的字体预加载 #13937

Closed
wants to merge 1 commit into from

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Jan 25, 2025

fix #13672

这个字体被加载了但是没有地方会使用

Image

这两行直接删掉应该就没问题了:

<link rel="preload" href="../../../appearance/fonts/Noto-COLRv1-2.047/Noto-COLRv1.woff2" as="font" type="font/woff2" crossorigin>
<link rel="preload" href="../../../appearance/fonts/JetBrainsMono-2.304/JetBrainsMono-Regular.woff2" as="font" type="font/woff2" crossorigin>

@TCOTC TCOTC mentioned this pull request Jan 25, 2025
3 tasks
@Vanessa219
Copy link
Member

这个用于代码块

@Vanessa219 Vanessa219 closed this Jan 29, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 29, 2025

相关代码在哪?

@Vanessa219
Copy link
Member

theme.css

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 29, 2025

不明白,我觉得这两行完全多余了

@Vanessa219
Copy link
Member

这个是一个代码块的备选字体。

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 29, 2025

但是你看我上面的截图,用不到这个字体文件(或者说重复加载了两个相同的字体文件)

Vanessa219 added a commit that referenced this pull request Jan 29, 2025
@Vanessa219
Copy link
Member

哦,是有点问题,已修改。

Vanessa219 added a commit that referenced this pull request Jan 30, 2025
@TCOTC TCOTC deleted the dev-remove-font branch February 3, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants