Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illegal state exception #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix illegal state exception #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1280764
catch IllegalStateException that can occur when application is runnin…
skeymeulen Jul 25, 2019
fbf587f
Return error in callback so we can handle this in implementation
skeymeulen Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/android/FingerprintAuthAux.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,12 @@ public void run() {
// Show the fingerprint dialog. The user has the option to use the fingerprint with
// crypto, or you can fall back to using a server-side verified password.
mFragment.setCryptoObject(new FingerprintManager.CryptoObject(mCipher));
mFragment.show(cordova.getActivity().getFragmentManager(), DIALOG_FRAGMENT_TAG);
try {
mFragment.show(cordova.getActivity().getFragmentManager(), DIALOG_FRAGMENT_TAG);
} catch (IllegalStateException ignored) {
mPluginResult = new PluginResult(PluginResult.Status.ERROR, "Failed to open fingerprint dialog");
mCallbackContext.sendPluginResult(mPluginResult);
}
} else {
mPluginResult = new PluginResult(PluginResult.Status.ERROR, "Failed to init Cipher");
mCallbackContext.sendPluginResult(mPluginResult);
Expand Down