Prefer collection expression

sjp · Feb 2, 2024 · 2583616 · 2583616
1 parent 01066e9
commit 2583616
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/SJP.Schematic.Lint/Rules/NoSurrogatePrimaryKeyRule.cs b/src/SJP.Schematic.Lint/Rules/NoSurrogatePrimaryKeyRule.cs
@@ -51,7 +51,7 @@ protected IEnumerable<IRuleMessage> AnalyseTable(IRelationalDatabaseTable table)
                 Some: pk =>
                 {
                     if (pk.Columns.Count == 1)
-                        return Array.Empty<IRuleMessage>();
+                        return [];
 
                     var fkColumns = table.ParentKeys
                         .Select(fk => fk.ChildKey)
@@ -62,7 +62,7 @@ protected IEnumerable<IRuleMessage> AnalyseTable(IRelationalDatabaseTable table)
 
                     var areAllColumnsFks = pk.Columns.All(c => fkColumns.Contains(c.Name.LocalName));
                     return areAllColumnsFks
-                        ? Array.Empty<IRuleMessage>()
+                        ? []
                         : [BuildMessage(table.Name)];
                 },
                 None: Array.Empty<IRuleMessage>

diff --git a/src/SJP.Schematic.Oracle/OracleRelationalDatabaseTableProvider.cs b/src/SJP.Schematic.Oracle/OracleRelationalDatabaseTableProvider.cs
@@ -692,7 +692,7 @@ private async Task<IReadOnlyCollection<IDatabaseTrigger>> LoadTriggersAsyncCore(
             var events = TriggerEvent.None;
             var triggerEventPieces = triggerRow.TriggerEvent != null
                 ? triggerRow.TriggerEvent.Split(new[] { " OR " }, StringSplitOptions.RemoveEmptyEntries)
-                : Array.Empty<string>();
+                : [];
 
             foreach (var triggerEventPiece in triggerEventPieces)
             {

diff --git a/src/SJP.Schematic.Tests.Utilities/DatabaseTestFixtureAttribute.cs b/src/SJP.Schematic.Tests.Utilities/DatabaseTestFixtureAttribute.cs
@@ -48,7 +48,7 @@ public DatabaseTestFixtureAttribute(Type target, string propertyName, string ign
         IDbConnectionFactory factory;
         try
         {
-            var methodResult = getMethod.Invoke(null, Array.Empty<object>());
+            var methodResult = getMethod.Invoke(null, []);
             if (methodResult is not IDbConnectionFactory connFactory)
             {
                 ResultCache.AddOrUpdate(getMethod, false, static (_, __) => false);

diff --git a/src/SJP.Schematic.Tests.Utilities/NoneConstraint.cs b/src/SJP.Schematic.Tests.Utilities/NoneConstraint.cs
@@ -32,7 +32,7 @@ public override ConstraintResult ApplyTo<TActual>(TActual actual)
             throw new ArgumentException($"Expected an Option<T> object, instead received {actualType.FullName}", nameof(actual));
 
         var propGet = actualType.GetProperty(nameof(Option<object>.IsNone))!.GetGetMethod()!;
-        var isNone = (bool)propGet.Invoke(actual, Array.Empty<object>())!;
+        var isNone = (bool)propGet.Invoke(actual, [])!;
 
         return new OptionConstraintResult(this, false, isNone);
     }

diff --git a/src/SJP.Schematic.Tests.Utilities/SomeConstraint.cs b/src/SJP.Schematic.Tests.Utilities/SomeConstraint.cs
@@ -32,7 +32,7 @@ public override ConstraintResult ApplyTo<TActual>(TActual actual)
             throw new ArgumentException($"Expected an Option<T> object, instead received {actualType.FullName}", nameof(actual));
 
         var propGet = actualType.GetProperty(nameof(Option<object>.IsSome))!.GetGetMethod()!;
-        var isSome = (bool)propGet.Invoke(actual, Array.Empty<object>())!;
+        var isSome = (bool)propGet.Invoke(actual, [])!;
 
         return new OptionConstraintResult(this, true, isSome);
     }