-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Nav.Tile id mandatory and update examples #3097
base: next
Are you sure you want to change the base?
Make Nav.Tile id mandatory and update examples #3097
Conversation
🦋 Changeset detectedLatest commit: c7ed062 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@phamduylong is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
sites/next.skeleton.dev/src/examples/components/navigation/ExampleExpanded.svelte
Outdated
Show resolved
Hide resolved
Not sure why the test fails but seems irrelevant for this PR. |
@phamduylong the CI tests are for specific apps, to As per the PR, this looks great. This should be ready to merge, but I'm going to hold it while we continue to release CLI updates. Once those settle down I'll merge and this can be part of the next proper release. |
Great. I have to modify the changeset before you merge it as well. |
Updated changeset. |
packages/skeleton-react/src/lib/components/Navigation/Navigation.test.tsx
Outdated
Show resolved
Hide resolved
26c2e90
to
c7ed062
Compare
Linked Issue
Closes #3085
Description
Make
id
mandatory on Nav.Tile instancesChangsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test