new_compliant_account and new_delinquent_account signals (#18)

* new_compliant_account and new_delinquent_account signals

* Credit card deleted delinquent consequences

* Add delete model also to tabular credit card admin

* Delete unused code

* Update version

billing/__init__.py

@@ -1,4 +1,4 @@
-__version__ = '1.7.22'
+__version__ = '1.7.23'
 __copyright__ = 'Copyright (c) 2020, Skioo SA'
 __licence__ = 'MIT'
 __URL__ = 'https://github.com/skioo/django-customer-billing'

billing/actions/accounts.py

@@ -23,6 +23,7 @@
     Account, CARRIED_FORWARD, CREDIT_REMAINING, Charge, CreditCard,
     EventLog, Invoice, ProductProperty, Transaction, total_amount,
 )
+from ..signals import new_compliant_account, new_delinquent_account
 
 logger = get_logger()
 
@@ -271,6 +272,7 @@ def mark_account_as_delinquent(account_id: UUID, reason: str):
             type=EventLog.NEW_DELINQUENT,
             text=reason,
         )
+        new_delinquent_account.send(sender=mark_account_as_delinquent, account=account)
 
 
 def mark_account_as_compliant(account_id: UUID, reason: str):
@@ -284,6 +286,7 @@ def mark_account_as_compliant(account_id: UUID, reason: str):
             type=EventLog.NEW_COMPLIANT,
             text=reason,
         )
+        new_compliant_account.send(sender=mark_account_as_compliant, account=account)
 
 
 def charge_pending_invoices(account_id: UUID) -> Dict[str, int]:

billing/admin.py

@@ -22,6 +22,7 @@
     Account, Charge, CreditCard, EventLog, Invoice, ProductProperty,
     Transaction,
 )
+from .signals import credit_card_deleted
 
 logger = get_logger()
 
@@ -188,6 +189,11 @@ class CreditCardAdmin(AppendOnlyModelAdmin):
     raw_id_fields = ['account']
     readonly_fields = ['created', 'modified', 'expiry_date']
 
+    def delete_model(self, request, obj):
+        account = obj.account
+        super().delete_model(request, obj)
+        credit_card_deleted.send(sender=CreditCardAdmin, account=account)
+
 
 class CreditCardInline(admin.TabularInline):
     model = CreditCard

billing/signals/__init__.py

@@ -6,5 +6,9 @@
 invoice_ready = Signal(use_caching=True)
 
 credit_card_registered = Signal()
+credit_card_deleted = Signal()
 
 debt_paid = Signal()
+
+new_delinquent_account = Signal()
+new_compliant_account = Signal()

billing/signals/handlers.py

@@ -1,9 +1,9 @@
 from django.dispatch import receiver
 from structlog import get_logger
 
-from . import credit_card_registered
-from ..models import CreditCard
+from . import credit_card_deleted, credit_card_registered
 from ..actions import accounts
+from ..models import Account, CreditCard
 
 logger = get_logger()
 
@@ -20,3 +20,16 @@ def credit_card_registered_handler(sender, credit_card: CreditCard, **kwargs):
             account.id,
             reason='A valid credit card has been registered'
         )
+
+
+@receiver(credit_card_deleted)
+def credit_card_deleted_handler(sender, account: Account, **kwargs):
+    if account.delinquent:
+        return
+
+    reasons = accounts.get_reasons_account_is_violating_delinquent_criteria(account.id)
+    if reasons:
+        accounts.mark_account_as_delinquent(
+            account.id,
+            reason='Account has not any valid credit card registered'
+        )