Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1713: Populated the SOURCE_HOST vanflow attribute in the http1… #1714

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Fixes #1713: Populated the SOURCE_HOST vanflow attribute in the http1… #1714

merged 4 commits into from
Jan 13, 2025

Conversation

ganeshmurthy
Copy link
Contributor

… adaptor

@ganeshmurthy ganeshmurthy requested a review from kgiusti January 10, 2025 21:02
kgiusti
kgiusti reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding a negative case where the x-forwarded value is garbage - specifically too long for you 128 byte input buffer.

src/observers/http1/http1_observer.c Fixed Show resolved Hide resolved
@ganeshmurthy
Copy link
Contributor Author

I'd recommend adding a negative case where the x-forwarded value is garbage - specifically too long for you 128 byte input buffer.

I added a long input to the both the http1 and http2 tests, please take a look

@ganeshmurthy
Copy link
Contributor Author

@kgiusti I have all the changes you requested, please take a look and approve.

@ganeshmurthy ganeshmurthy merged commit e17bc6d into skupperproject:main Jan 13, 2025
37 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgiusti kgiusti kgiusti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshmurthy @kgiusti