generated from slack-samples/deno-starter-template
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap datastore operations for deno-slack-data-mapper #2
Draft
zimeg
wants to merge
15
commits into
main
Choose a base branch
from
datastore-mapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to have a larger discussion about introducing (or not) external libraries into our samples before we go this route |
@misscoded absolutely! Just wanted to test this out and share the findings! Planning on keeping it in draft, but can close it if you'd prefer 😄 |
@E-Zim Sounds good and I'm glad you're testing it out. And nope, feel free to keep the issue open in the meantime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
As an experiment, this PR swaps the native datastore operations for those in the deno-slack-data-mapper module. This comparison shows great simplifications provided for the
put
,delete
, and (especially)query
operations.A note on the
required
propertyThe datastore schema properties are currently used as an input property in multiple functions and results in an internal error if the
required
property is contained in these attributes. To avoid this, additional logic was added to insert therequired
property for the actual datastore schema while leaving the properties untouched.Requirements