Merge pull request globus#620 from sirosen/cleanup-linting-sdk-tests

Cleanup linting on sdk tests
slateci · Nov 9, 2021 · 1cb3388 · 1cb3388
2 parents cf58f7f + ce95c08
commit 1cb3388
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 10 deletions.
diff --git a/funcx_sdk/funcx/tests/conftest.py b/funcx_sdk/funcx/tests/conftest.py
@@ -4,7 +4,7 @@
 from funcx.sdk.executor import FuncXExecutor
 
 config = {
-    "funcx_service_address": "https://api2.funcx.org/v2",  # For testing against local k8s
+    "funcx_service_address": "https://api2.funcx.org/v2",
     "endpoint_uuid": "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa",
     "results_ws_uri": "wss://api2.funcx.org/ws/v2/",
 }

diff --git a/funcx_sdk/funcx/tests/test_errors/test_invalid_endpoint.py b/funcx_sdk/funcx/tests/test_errors/test_invalid_endpoint.py
@@ -1,6 +1,5 @@
 import pytest
 
-from funcx.sdk.client import FuncXClient
 from funcx.utils.response_errors import EndpointNotFound
 
 

diff --git a/funcx_sdk/funcx/tests/test_errors/test_invalid_function.py b/funcx_sdk/funcx/tests/test_errors/test_invalid_function.py
@@ -1,8 +1,5 @@
-import time
-
 import pytest
 
-from funcx.sdk.client import FuncXClient
 from funcx.utils.response_errors import FunctionNotFound
 
 

diff --git a/funcx_sdk/funcx/tests/test_executor.py b/funcx_sdk/funcx/tests/test_executor.py
@@ -177,7 +177,8 @@ def test_batch_delays(batch_fx, endpoint):
 
 
 # test locally: python3 test_executor.py -e <endpoint_id>
-# test on dev: python3 test_executor.py -s https://api2.dev.funcx.org/v2 -w wss://api2.dev.funcx.org/ws/v2/ -e <endpoint_id>
+# test on dev:
+#   python3 test_executor.py -s https://api2.dev.funcx.org/v2 -w wss://api2.dev.funcx.org/ws/v2/ -e <endpoint_id>    # noqa:E501
 if __name__ == "__main__":
     parser = argparse.ArgumentParser()
     parser.add_argument(

diff --git a/funcx_sdk/funcx/tests/test_performance/test_performance.py b/funcx_sdk/funcx/tests/test_performance/test_performance.py
@@ -2,8 +2,6 @@
 
 import pytest
 
-from funcx.sdk.client import FuncXClient
-
 
 def double(x):
     return x * 2

diff --git a/funcx_sdk/funcx/tests/test_result_size.py b/funcx_sdk/funcx/tests/test_result_size.py
@@ -1,6 +1,5 @@
 import pytest
 
-from funcx.sdk.client import FuncXClient
 from funcx.utils.errors import TaskPending
 from funcx_endpoint.executors.high_throughput.funcx_worker import MaxResultSizeExceeded
 
@@ -47,7 +46,10 @@ def test_allowed_result_sizes(fxc, endpoint, size):
 
 
 def test_result_size_too_large(fxc, endpoint, size=550000):
-    """funcX should raise a MaxResultSizeExceeded exception when results exceeds 512KB limit"""
+    """
+    funcX should raise a MaxResultSizeExceeded exception when results exceeds 512KB
+    limit
+    """
     fn_uuid = fxc.register_function(
         large_result_producer, endpoint, description="LargeResultProducer"
     )