This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
fixed query exchange state ticker #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slazarov
reviewed
Aug 5, 2018
| @@ -195,6 +195,7 @@ def disconnect(self): | |||
| async def _is_query_invoke(self, kwargs): | |||
| if 'R' in kwargs and type(kwargs['R']) is not bool: | |||
| invoke = self.invokes[int(kwargs['I'])]['invoke'] | |||
| ticker = self.invokes[int(kwargs['I'])].get('ticker') | |||
There was a problem hiding this comment.
Should be omitted from here because private methods also pass through _is_query_invoke and this would put the api keys in the payload.
Should replace line 207, i.e msg['ticker']=self.invokes[int(kwargs['I'])].get('ticker')
slazarov
reviewed
Aug 5, 2018
| @@ -203,6 +204,7 @@ def disconnect(self): | |||
| msg = await process_message(kwargs['R']) | |||
| if msg is not None: | |||
| msg['invoke_type'] = invoke | |||
| msg['M'] = ticker | |||
There was a problem hiding this comment.
msg['ticker']=self.invokes[int(kwargs['I'])].get('ticker')I don't use ['M'] for the reason given in here.
|
Hi, the threaded version is a few commits ahead. I've made some recommendations to your PR. Once we concluded them, we can commit the changes. I use 'ticker' because the official endpoint doesn't yield the market ('M') and I want to distinguish it, i.e it's not a native property. Also described in here. |
slazarov
added a commit
that referenced
this pull request
Aug 29, 2018
|
Part of changes added in d3b29cf. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query exchange state wasn't returning the market under 'M'.
I noticed in the threaded version you're putting it under 'ticker' is there a reason for this? Probably makes sense to unify.....