Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-179 Catch 404 exception if no FS form matches XML content when uploading drafts #531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GO-179 Catch 404 exception if no FS form matches XML content when uploading drafts #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/models/fs/message_draft.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ def self.create_and_validate_with_fs_form(form_files: [], author:, fs_client: Fs

form_files.each do |form_file|
form_content = form_file.read.force_encoding("UTF-8")
form_information = fs_client.api.parse_form(form_content)
begin
form_information = fs_client.api.parse_form(form_content)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toto by som strcil dovnutra, ak je ocakavane, ze nastane validacna chyba, tak by sme to nemali riesit exception. rep. urcite nechytajme vsetky vynimky takto ale len tie co mozu naozaj nastat lebo to bude nedebugovtelne.

rescue
messages << nil
next
end
dic = form_information['subject']&.strip
fs_form_identifier = form_information['form_identifier']

Expand Down
Loading