Fix angle warning #231
Merged
Fix angle warning #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I put as limit for the test 5 degrees deviations from multiples of 90 degrees as small deviations seem to not cause difficulties, however I misplaced the closing parenthesis, so the 5 degrees margin was only active for angles larger than a multiple of 90 degrees.
This test case now triggers a call to rlang::warn()
|
Good catch! Thank you for coming back to fix it with another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slowkow Hi. Some time ago I added a warning for angles as part of pull-request #196. I put as limit for the test plus/minus 5-degrees deviations from multiples of 90 degrees as small deviations seem to not cause difficulties with repulsion, however I misplaced the closing parenthesis, so the 5 degrees margin was only active for angles larger than a multiple of 90 degrees. This pull request fixes this. Because it now triggers a call to
rlang::warn(), I commented out a test case.