[TT-1490] add gas bumping #40
Conversation
Tofel
force-pushed
the
tt_1490_gas_bumping
branch
from
84f0490 to
19a46a1
Compare
…e more independent, update readme with max gas price
Tofel
force-pushed
the
tt_1490_gas_bumping
branch
from
40eda12 to
76afc61
Compare
README.md
Outdated
| - for Blob transactions (EIP-4844) it's the sum of gas fee cap and tip cap and max fee per blob | ||
| - for AccessList transactions (EIP-2930) it's just the gas price | ||
|
|
||
| Please note that Blob and AccessList |
There was a problem hiding this comment.
Should we end the sentence? =)
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Currently, the gas bumping mechanism is available for: |
There was a problem hiding this comment.
Let's remove these lines, we've already described them before, or shorten it
| retry.DelayType(retry.FixedDelay), | ||
| // unless attempts is at least 1 retry.Do won't execute at all | ||
| retry.Attempts(func() uint { | ||
| if m.Cfg.GasBumpRetries() == 0 { |
There was a problem hiding this comment.
Is it strictly 1 attempt still or 2 attempts, 1 initial and 1 after?
There was a problem hiding this comment.
that's the thing, if attempts is 0 no retry will ever be done
|
|
||
| Don't worry if while bumping logic executes previous transaction gets mined. In that case sending replacement transaction with higher gas will fail (because it is using the same nonce as original transaction) and we will retry waiting for the mining of the original transaction. | ||
|
|
||
| **Gas bumping is only applied for submitted transaction. If transaction was rejected by the node (e.g. because of too low base fee) we will not bump the gas price nor try to submit it, because original transaction submission happens outside of Seth.** |
There was a problem hiding this comment.
Sadly enough, that's true, haven't found any other possible workarounds?
transact in generated bindings returns nil if it fails to send
if err := c.transactor.SendTransaction(ensureContext(opts.Context), signedTx); err != nil {
return nil, err
}
return signedTx, nil
There was a problem hiding this comment.
yup so inside Decode() we don't have the transaction so we cannot resubmit it, the only solution I can think of is what I described to you yesterday:
- implement
Backend - proxy
SendTransactionto original one - if err, retry inside our implementation of
SendTransaction
retry.go
Outdated
| // +30% | ||
| return func(gasPrice *big.Int) *big.Int { | ||
| gasPriceFloat, _ := gasPrice.Float64() | ||
| newGasPriceFloat := big.NewFloat(0.0).Mul(big.NewFloat(gasPriceFloat), big.NewFloat(1.5)) |
There was a problem hiding this comment.
Did you mean 1.3 for 30%?
this PR adds gas bumping for transactions that are slow to confirm. that means that they need to be successfully submitted and cannot be reverted. by default bumping is disabled (
retries = 0). there's also an option to specify max gas price in wei.gas bumping can be used, when deploying contracts via
DeployContract()function and insideDecode()function, when waiting for tx to be mined.following tests were added: