Contributions to OpenVPN #1
Conversation
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-22.04] |
There was a problem hiding this comment.
Do they use specific versions or ubuntu-latest in other builds?
There was a problem hiding this comment.
Using ubuntu 22.04. Copied most of the boilerplate from other tests. Changed all the build steps tho
.github/workflows/build.yaml
Outdated
| with: | ||
| path: aws-lc | ||
| repository: aws/aws-lc | ||
| ref: main |
There was a problem hiding this comment.
For their other libcryptos do they use a specific release or follow main?
There was a problem hiding this comment.
mbedtls and libressl use a tagged release, but I think we should be following main to have two way compatibility checks. I guess we're testing mainline LC in our CI with OpenVPN anyway so we don't need to. I don't have a preference, thoughts?
There was a problem hiding this comment.
Good point, if we're building their main and not running into any breaking changes then this is probably fine. I just don't want to create noise in their CI if something subtle changes.
|
|
||
| ************************************************************************* | ||
| Due to limitations in AWS-LC, the following features are missing | ||
| * Windows CryptoAPI support |
There was a problem hiding this comment.
Does this effect OpenVPN customers? Can you use OpenVPN through the Windows CryptoAPI? Or does OpenVPN use Windows CryptoAPI to do something that doesn't work with AWS-LC now?
There was a problem hiding this comment.
Looks like OpenVPN has some support for the Windows CryptoAPI. OpenSSL has some APIs that seem to work with CryptoAPI but we don't support these like wolfssl and mbedtls
This is a local PR to gather internal feedback before we contribute these changes to OpenVPN.
Thank you for your contribution
You are welcome to open PR, but they are used for discussion only. All
patches must eventually go to the openvpn-devel mailing list for review:
Please send your patch using git-send-email. For example to send your latest commit to the list:
For details, see these Wiki articles: