Add test and fix gen 7 onSwitchInPriority #10842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unnused choices * Remove redundant isStarted * Override runSwitch * Complete comment * Reset abilityState.started * Update data/mods/gen7letsgo/scripts.ts --------- Co-authored-by: pyuk-bot
Previously a race condition
Necessary?
|
@andrebastosdias it looks like your rebase got botched, can you fix that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this PR directly on the branch before the SwitchIn overhaul merge.
I'm not sure if all the changes are correct, particularly whether the
Move: 2is necessary. I changed the method calls tosingleEventsimply because that's how it is done across all the other effects.Healing Wish and Lunar Dance need their
onSwitchInPriorityupdated in the Gen 7 mod to match Gen 9.I also added a test for the Throat Spray/Magician race condition reported here.