feat: add aws_region #38
Conversation
|
Warning Rate limit exceeded@jakevc has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 38 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request introduces an optional Changes
Sequence DiagramsequenceDiagram
participant User
participant StorageProviderSettings
participant StorageProvider
participant S3Client
User->>StorageProviderSettings: Configure with optional aws_region
StorageProviderSettings->>StorageProvider: Pass configuration
StorageProvider->>S3Client: Initialize with specified region
StorageProvider->>S3Client: Create bucket with region constraint (if specified)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
snakemake_storage_plugin_s3/__init__.py(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
snakemake_storage_plugin_s3/__init__.py (1)
Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.
🪛 Ruff (0.8.2)
snakemake_storage_plugin_s3/__init__.py
63-63: SyntaxError: Expected an expression or a '}'
64-64: SyntaxError: Expected ':', found string
64-64: SyntaxError: Expected ',', found ':'
65-65: SyntaxError: Expected ':', found '}'
🪛 GitHub Actions: CI
snakemake_storage_plugin_s3/__init__.py
[error] 63-63: SyntaxError: invalid syntax
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
I think play.mino.io is down tonight, which is why I started to stub out the ability to use a TestWorkflowsS3StorageBase, which then needed this aws_region parameter I implemented here, but then tests are still hanging because play.minio.io is unresponsive haha |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/docker-compose.yml (1)
1-11: LGTM! The MinIO service is properly configured for testing.The Docker Compose configuration correctly sets up a local MinIO service with appropriate port mapping and credentials that match the test configuration.
Add a newline at the end of the file to comply with YAML formatting standards:
command: server /data +🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 11-11: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/ci.yml(2 hunks)snakemake_storage_plugin_s3/__init__.py(3 hunks)tests/docker-compose.yml(1 hunks)tests/tests.py(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- snakemake_storage_plugin_s3/init.py
🧰 Additional context used
📓 Path-based instructions (1)
tests/tests.py (1)
Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.
🪛 YAMLlint (1.35.1)
tests/docker-compose.yml
[error] 11-11: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
tests/tests.py (1)
34-36: LGTM! The storage provider settings are correctly configured for local MinIO.The endpoint URL and credentials are properly aligned with the local MinIO service configuration defined in the Docker Compose file.
.github/workflows/ci.yml (2)
85-89: LGTM! Docker Compose setup is properly configured.The setup correctly updates and installs Docker Compose for the MinIO service.
90-92: LGTM! MinIO service is started correctly.The Docker Compose file is properly referenced and the service is started in detached mode.
|
setting up and switch to a local server for CI/CD solves this problem as play.minio.io stilll looks to be down @johanneskoester |
|
TestWorkflowsMinioLocalStorageBase could be placed with the others in snakemake.common.tests, but it's included here to prove the concept |
This PR adds aws_region to StorageProviderSettings
Summary by CodeRabbit
New Features
Improvements