[nation3-passport-coop-with-delegations] Update behaviour on revoked passports by querying subgraph #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and covers our use cases
Update the Nation3 Snapshot voting strategy to use delegated voting weight properly
Bump version as requested!
How cooperative model might work
Co-authored-by: Chaitanya <[email protected]>
Co-authored-by: Chaitanya <[email protected]>
Co-authored-by: Chaitanya <[email protected]>
As requested
Updated to read the balance of veNation for the Passport Holder and filter when less than 1.5
Co-authored-by: ChaituVR <[email protected]>
🐛 Fix breaking issue with revoked passports
ChaituVR
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Uses a simple subgraph to query for revoked passports and excludes them from the vote - previously these passports would cause Txs to revert.