Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-v2] fix: do not log response body on network error #1401

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[api-v2] fix: do not log response body on network error #1401

merged 2 commits into from
Jan 31, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jan 31, 2024 •
edited
Loading

Changes proposed in this pull request:

  • when parsing the API response is failing, and response code is not OK, do not log the body, as it's irrelevant, and always something like <html><title>502 error ...

Will make the log easier to read, and reduce noise, error code is enough in that case

@wa0x6e wa0x6e requested a review from ChaituVR January 31, 2024 12:19
@ChaituVR ChaituVR merged commit e1f49b2 into master Jan 31, 2024
9 checks passed
@ChaituVR ChaituVR deleted the api-v2-do-not-log-body-on-network-error branch January 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
strategy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR