[spooky-lp-sonic] Added spooky-lp-sonic strategy and updated index.ts #1677
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
changed the title
ChaituVR
reviewed
Jan 22, 2025
|
@ChaituVR it should be fixed |
ChaituVR
requested changes
Jan 23, 2025
Co-authored-by: Chaitanya <[email protected]>
* Remove try-catch block around subgraphRequest
|
@ChaituVR fixed again! |
ChaituVR
reviewed
Jan 23, 2025
ChaituVR
approved these changes
Jan 23, 2025
|
@ChaituVR how long does it take for the strategy to show up on snapshot |
0xaaiden
commented
Jan 24, 2025
There was a problem hiding this comment.
@ChaituVR can you reopen the PR, there is an issue with the network id, it should be 146 for sonic instead of ethereum @BounebRayan
|
@0xaaiden Feel free to create a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new strategy called
spooky-lp-sonicfor calculating liquidity positions in $BOO pools. The changes include adding the new strategy to the list of strategies, creating a README file for documentation, providing example queries, and implementing the strategy logic.New Strategy Implementation:
Strategy Addition:
spooky-lp-sonicto the list of strategies insrc/strategies/index.ts.Documentation:
src/strategies/spooky-lp-sonic/README.mdto document the new strategy, including an overview of the pools queried and the method used to calculate net liquidity.Example Queries:
src/strategies/spooky-lp-sonic/examples.jsonto provide example queries for the new strategy.Strategy Logic:
spooky-lp-sonicstrategy insrc/strategies/spooky-lp-sonic/index.ts, including functions to query subgraph data, handle pagination, and calculate net liquidity positions.