Remove netcoreapp3.1 and net5.0 from tests

snowflakedb · May 14, 2024 · 98f3e58 · 98f3e58
1 parent 1e36fb0
commit 98f3e58
Showing 1 changed file with 2 additions and 59 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -34,7 +34,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        dotnet: ['netcoreapp3.1', 'net5.0', 'net6.0', 'net7.0', 'net8.0', 'net462', 'net471', 'net472', 'net48', 'net481']
+        dotnet: ['net6.0', 'net7.0', 'net8.0', 'net462', 'net471', 'net472', 'net48', 'net481']
         cloud_env: ['AZURE', 'GCP', 'AWS']
     steps:
       - name: Checkout code
@@ -93,7 +93,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        dotnet: ['net5.0', 'net6.0', 'net7.0', 'net8.0']
+        dotnet: ['net6.0', 'net7.0', 'net8.0']
         cloud_env: ['AZURE', 'GCP', 'AWS']
     steps:
       - uses: actions/checkout@v3
@@ -200,60 +200,3 @@ jobs:
           token: ${{ secrets.CODE_COV_UPLOAD_TOKEN }}
           fail_ci_if_error: true
           files: Snowflake.Data.Tests/macos_${{ matrix.dotnet }}_${{ matrix.cloud_env }}_coverage.xml
-
-  test-macx64:
-    name: Tests on MAC x64
-    runs-on: macos-13
-    strategy:
-      fail-fast: false
-      matrix:
-        dotnet: ['net5.0']
-        cloud_env: ['AZURE', 'GCP', 'AWS']
-    steps:
-      - uses: actions/checkout@v3
-      - name: Setup Dotnet
-        uses: actions/setup-dotnet@v3
-        with:
-          dotnet-version: '8.0.x'
-          dotnet-quality: 'ga'
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: '3.x'
-      - name: Setup dotnet-coverage
-        run: dotnet tool install --global dotnet-coverage --version 17.8.4
-      - name: Decrypt Parameters
-        shell: bash
-        env:
-          PARAMETER_SECRET: ${{ secrets.PARAMETER_SECRET }}
-        run: |
-          gpg --quiet --batch --yes --decrypt --passphrase="$PARAMETER_SECRET" \
-           ./.github/workflows/parameters/parameters_${{ matrix.cloud_env }}.json.gpg > Snowflake.Data.Tests/parameters.json
-      - name: Build Driver
-        run: |
-          dotnet restore
-          dotnet build
-      - name: Run Tests
-        run: |
-          cd Snowflake.Data.Tests
-          dotnet-coverage collect "dotnet test --framework ${{ matrix.dotnet }} --no-build -l console;verbosity=normal" --output macos_${{ matrix.dotnet }}_${{ matrix.cloud_env }}_coverage.xml --output-format cobertura --settings coverage.config
-        env:
-          snowflake_cloud_env: ${{ matrix.cloud_env }}
-          net_version: ${{ matrix.dotnet }}
-      - name: Upload Code Coverage Report
-        uses: actions/upload-artifact@v3
-        with:
-          name: code-coverage-report
-          path: Snowflake.Data.Tests/macos_${{ matrix.dotnet }}_${{ matrix.cloud_env }}_coverage.xml
-      - name: Upload Test Performance Report
-        uses: actions/upload-artifact@v3
-        with:
-          name: tests-performance
-          path: Snowflake.Data.Tests/macos_${{ matrix.dotnet }}_${{ matrix.cloud_env }}_performance.csv
-      - name: Upload coverage reports to Codecov
-        uses: codecov/codecov-action@v3
-        with:
-          # without the token code cov may fail because of Github limits https://github.com/codecov/codecov-action/issues/557
-          token: ${{ secrets.CODE_COV_UPLOAD_TOKEN }}
-          fail_ci_if_error: true
-          files: Snowflake.Data.Tests/macos_${{ matrix.dotnet }}_${{ matrix.cloud_env }}_coverage.xml