Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-1881731] Add externalBrowser, oauth, okta, keypair automated authentication tests #1082

Merged
merged 44 commits into from
Jan 31, 2025

Conversation

sfc-gh-pcyrek
Copy link
Contributor

@sfc-gh-pcyrek sfc-gh-pcyrek commented Jan 23, 2025

Description

Please explain the changes you made here.

This PR adds automated tests for externalBrowser, oauth, okta, keypair authentication methods

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (444a2c1) to head (b75825e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   86.23%   86.33%   +0.10%     
==========================================
  Files         132      132              
  Lines       12664    12664              
  Branches     1299     1299              
==========================================
+ Hits        10921    10934      +13     
+ Misses       1417     1406      -11     
+ Partials      326      324       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pcyrek sfc-gh-pcyrek marked this pull request as ready for review January 29, 2025 13:10
@sfc-gh-pcyrek sfc-gh-pcyrek requested a review from a team as a code owner January 29, 2025 13:10
@sfc-gh-pcyrek sfc-gh-pcyrek merged commit 75532c9 into master Jan 31, 2025
61 of 63 checks passed
@sfc-gh-pcyrek sfc-gh-pcyrek deleted the pcyrek/authentication-tests branch January 31, 2025 08:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants