-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1848371 adding connection.is_valid to perform connection validation on TCP/IP and Session levels #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion on TCP/IP and Session levels
sfc-gh-dszmolka
added
the
DO_NOT_PORT_CHANGES_TO_SP
Add this label when changes in this PR do not need to be port to SP connector
label
Dec 11, 2024
sfc-gh-mkeller
requested changes
Dec 19, 2024
Co-authored-by: Mark Keller <[email protected]>
Co-authored-by: Mark Keller <[email protected]>
Co-authored-by: Mark Keller <[email protected]>
sfc-gh-mkeller
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deal with the small comment first, otherwise looks great. Thank you!
🚢 🚢
Co-authored-by: Mark Keller <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP
Add this label when changes in this PR do not need to be port to SP connector
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1848371
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The PR is for covering a gap where seemingly there's no convenience method to tell 'is this connection still good enough to send queries over it?' . See details in the jira, but basically motivated by the situation where the cloud provider LB tears down the underlying idle connection unilaterally without telling the client, who then tries the submit the next query after the idleness ends, over a socket which is already closed on the other end - ending up with an error.
Having such a mechanism which the Node.js driver already has, gives the users a tool to conveniently control if the connection/session is still valid or they need to do something about it.
Plus fixing two very minor typos.