Skip to content

Commit

Permalink
Adds livenessProbe to iglu deployment (closes #175)
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesarems committed Jul 25, 2024
1 parent adc2fcd commit 3473a95
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/snowplow-iglu-server/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: snowplow-iglu-server
description: A Helm Chart to deploy the Snowplow Iglu Server project
version: 0.5.0
version: 0.6.0
appVersion: "0.12.0"
icon: https://raw.githubusercontent.com/snowplow-devops/helm-charts/master/docs/logo/snowplow.png
home: https://github.com/snowplow-devops/helm-charts
Expand Down
5 changes: 4 additions & 1 deletion charts/snowplow-iglu-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ You will need to fill these targeted fields:
| service.maxReplicas | int | `4` | |
| service.minReplicas | int | `1` | |
| service.port | int | `8080` | Port to bind and expose the service on |
| service.livenessProbe.failureThreshold | int | `3` | |
| service.livenessProbe.initialDelaySeconds | int | `30` | |
| service.livenessProbe.periodSeconds | int | `5` | |
| service.livenessProbe.timeoutSeconds | int | `5` | |
| service.readinessProbe.failureThreshold | int | `3` | |
| service.readinessProbe.initialDelaySeconds | int | `5` | |
| service.readinessProbe.periodSeconds | int | `5` | |
Expand All @@ -194,4 +198,3 @@ You will need to fill these targeted fields:
| service.resources.requests.memory | string | `"512Mi"` | |
| service.targetCPUUtilizationPercentage | int | `75` | |
| service.terminationGracePeriodSeconds | int | `630` | |

12 changes: 11 additions & 1 deletion charts/snowplow-iglu-server/templates/iglu-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ spec:
- secretRef:
name: {{ include "iglu.app.secret.name" . }}

livenessProbe:
httpGet:
path: /api/meta/health
port: {{ .Values.service.port }}
scheme: HTTP
initialDelaySeconds: {{ .Values.service.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.service.livenessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.service.livenessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.service.livenessProbe.failureThreshold }}

readinessProbe:
httpGet:
path: /api/meta/health
Expand All @@ -94,7 +104,7 @@ spec:
periodSeconds: {{ .Values.service.readinessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.service.readinessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.service.readinessProbe.failureThreshold }}
successThreshold: {{ .Values.service.readinessProbe.successThreshold }}
successThreshold: {{ .Values.service.readinessProbe.successThreshold }}

resources:
{{- toYaml .Values.service.resources | nindent 10 }}
Expand Down
6 changes: 6 additions & 0 deletions charts/snowplow-iglu-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ service:
targetCPUUtilizationPercentage: 75
terminationGracePeriodSeconds: 630

livenessProbe:
initialDelaySeconds: 30
periodSeconds: 5
timeoutSeconds: 5
failureThreshold: 3

readinessProbe:
initialDelaySeconds: 5
periodSeconds: 5
Expand Down

0 comments on commit 3473a95

Please sign in to comment.