Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts/services-deployment add rollingUpdate settings (closes #144) #146

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

ianarsenault
Copy link
Contributor

@ianarsenault ianarsenault commented Dec 3, 2023

This PR adds in additional settings for deployment.strategy for when RollingUpdate is set, you will be able to set the maxSurge and maxUnavailable settings rather than relying on defaults.

@ianarsenault ianarsenault force-pushed the service-deployent/rollingUpdate branch 2 times, most recently from 25c8cb1 to 770cf1e Compare December 3, 2023 19:16
@ianarsenault ianarsenault force-pushed the service-deployent/rollingUpdate branch from 770cf1e to f7c4b58 Compare December 3, 2023 19:19
Copy link
Contributor

@Andy-Hay Andy-Hay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianarsenault ianarsenault merged commit 2182934 into main Dec 3, 2023
1 check passed
@ianarsenault ianarsenault deleted the service-deployent/rollingUpdate branch December 3, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants