Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Deployment v0.18.0 with StatefulSets #171

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

jbeemster
Copy link
Member

@jbeemster jbeemster commented Mar 27, 2024

This update allows us to leverage the existing chart as a StatefulSet with full PVC support baked in. The main difference between these two kinds of deployment is that:

  1. Each pod in a StatefulSet has a consistent numerically iterated name (this also applies to upgrade order)
  2. When PVCs are enabled rather than creating a single volume for all pods to share we instead shift to a volumeTemplate that lets us create a PVC per pod. These volumes get re-attached to the pod with the same name when upgrades happen / pods move between k8s cluster nodes.
  3. The behaviour of PVCs in this mode can also be controlled to either Retain or Delete the volume. By default I have set that on scale_down we Delete the PVC but when we issue a general service removal (helm delete) this retains the volumes (this is the default in the docs) - a user should configure this to suit their own needs!

@jbeemster jbeemster force-pushed the charts-service-deployment-0.17.0 branch from 447708a to 0edc77d Compare March 27, 2024 13:56
@jbeemster jbeemster changed the title Service Deployment v0.17.0 with StatefulSets Service Deployment v0.18.0 with StatefulSets Mar 27, 2024
Copy link
Contributor

@istreeter istreeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this from Data Processing point of view.

Copy link
Contributor

@jparavisini jparavisini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbeemster jbeemster merged commit 918b6d8 into main Mar 28, 2024
1 check passed
@jbeemster jbeemster deleted the charts-service-deployment-0.17.0 branch March 28, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants