Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts/service-deployment: Add support for global labels (closes #177) #178

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

ianarsenault
Copy link
Contributor

This PR adds support for passing in global labels which will be applied to all resources deployed by the chart.

@ianarsenault ianarsenault marked this pull request as draft July 31, 2024 03:36
@ianarsenault ianarsenault force-pushed the charts/service-deployment-global-labels branch from 74b3eb9 to cad3a0b Compare July 31, 2024 03:42
@ianarsenault ianarsenault force-pushed the charts/service-deployment-global-labels branch from cad3a0b to 1ff0c3a Compare July 31, 2024 03:45
@ianarsenault ianarsenault marked this pull request as ready for review July 31, 2024 03:49
@ianarsenault ianarsenault self-assigned this Jul 31, 2024
Copy link
Contributor

@Andy-Hay Andy-Hay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianarsenault ianarsenault merged commit c124a81 into main Jul 31, 2024
1 check passed
@ianarsenault ianarsenault deleted the charts/service-deployment-global-labels branch July 31, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants