Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts/service-deployment add tolerations and topologySpreadConstraints #193

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

ianarsenault
Copy link
Contributor

This PR updates service-deployment helm chart to supprt

Also updates the global labels to remove leading empty space.

Before

# Source: service-deployment/templates/hpa.yaml
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
  name: sd
  labels:

    helm.sh/chart: service-deployment-0.20.0
    app.kubernetes.io/version: "0.20.0"
    app.kubernetes.io/managed-by: Helm
spec:

After

# Source: service-deployment/templates/hpa.yaml
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
  name: sd
  labels:
    helm.sh/chart: service-deployment-0.20.0
    app.kubernetes.io/version: "0.20.0"
    app.kubernetes.io/managed-by: Helm

@ianarsenault ianarsenault self-assigned this Aug 27, 2024
@ianarsenault ianarsenault marked this pull request as ready for review August 27, 2024 18:13
Copy link
Contributor

@jamesarems jamesarems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianarsenault ianarsenault merged commit 5bae8f9 into main Aug 28, 2024
1 check passed
@ianarsenault ianarsenault deleted the service-deployment/topologySpreadConstraints branch August 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants