Remove prefetch from pubsub source #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `prefetchN` in the pubsub source was complicated because: 1. The preceding `parEvalMapUnordered` effectively does a pre-fetch already 2. PrefetchN works in chunks, so there was a danger our Source was pre-fetching more batches from pubsub than expected. 3. It gave a double-meaning to the `parallelPullCount` config param, because the same param got used in two places. Which is just confusing. Moreover, I found it just wasn't needed. The input rate of this Source is high enough without the prefetch.
pondzix
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
prefetchNin the pubsub source was complicated because:parEvalMapUnorderedeffectively does a pre-fetch alreadyparallelPullCountconfig param, because the same param got used in two places. Which is just confusing.Moreover, I found it just wasn't needed. The input rate of this Source is high enough without the prefetch.