Enable a Defaults mode on AWS clients #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjben
approved these changes
Nov 6, 2023
istreeter
force-pushed
the
aws-retry-policy
branch
from
d9c399b to
80dff80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults mode is described in this AWS blog post.
By enabling a default mode, the client adapts to pick an appropriate retry policy and network settings.
Without this setting, the SDK does not do any retries. In the past we have implemented our own retry logic. But I prefer this way because I trust the sdk to know which error categories should be retried. And it makes the aws clients consistent with our gcp/kafka clients, which also do retries under-the-hood.