Make NVP codec isomorphic #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peel
force-pushed
the
bug/nvps-codec-is-not-isomorphic
branch
from
5198027 to
e75db58
Compare
NVP (Name-Value-Pair) type casts all the source values into plain `String`. This causes problems when a value is encoded differently and a different type is required when recovering a failed event. We need a smarter way of dealing with that. Ideally Name-Value-Pair should be removed, but until then we need an alternative codec that will somehow restore the type.
peel
force-pushed
the
bug/nvps-codec-is-not-isomorphic
branch
from
78182a8 to
f1efe9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVP (Name-Value-Pair) codec in
snowplow-badrowstype casts all the source values into plainString. This causes problems when a value is encoded differently and a different type is required when recovering a failed event.We need a smarter way of dealing with that. Ideally Name-Value-Pair should be removed, but until then we need an alternative codec that will somehow restore the type.