Add support for picture-in-picture playback of videos across multiple pages/screens (close #70) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlh1994
suggested changes
Jun 14, 2024
… pages/screens (close #70)
matus-tomlein
force-pushed
the
issue/70-pip_multi_page_view_id_playback
branch
from
1d8fad0 to
ff1b6ee
Compare
…ort multiple aggregations with different order by
|
@rlh1994 can you please take another look? I had to add a CTE in the base_this_run table because Redshift couldn't handle two |
rlh1994
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Issue #70
A video played in picture-in-picture (PIP) mode may produce events events with multiple different page view IDs. Currently we assume that a playback belongs to only a single page view ID.
This PR allows for the play to cover multiple page view IDs and add a column in the media base table that lists all of the page view IDs. The existing
page_view_idcolumn is kept and refers to the first page view id in the play.Checklist