Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media player for Spark ( Iceberg ) Support RC1 #77

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Media player for Spark ( Iceberg ) Support RC1 #77

merged 6 commits into from
Sep 25, 2024

Conversation

ilias1111
Copy link
Contributor

Description & motivation

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have raised a documentation PR if applicable (Link here)

@ilias1111 ilias1111 requested a review from a team as a code owner September 18, 2024 10:40
@ilias1111 ilias1111 changed the base branch from main to Release/snowplow-media-player/0.8.0 September 18, 2024 10:42
@ilias1111 ilias1111 removed the request for review from a team September 18, 2024 12:23
@ilias1111 ilias1111 changed the title Prepare code base for spark Media player for Spark ( Iceberg ) Support RC1 Sep 19, 2024
agnessnowplow
agnessnowplow approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilias1111 ilias1111 merged commit 418f9f2 into Release/snowplow-media-player/0.8.0 Sep 25, 2024
6 checks passed
@agnessnowplow agnessnowplow deleted the spark_rc_1 branch October 17, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnessnowplow agnessnowplow agnessnowplow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilias1111 @agnessnowplow