Add app id pe 6692 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
OscarSnowPlow
changed the base branch from
main
to
Release-snowplow-media-player/0.10.0
agnessnowplow
approved these changes
Oct 21, 2024
OscarSnowPlow
merged commit da0665c
into
Release-snowplow-media-player/0.9.1
6 checks passed
ilias1111
pushed a commit
that referenced
this pull request
Oct 23, 2024
Added app_id column to models
ilias1111
pushed a commit
that referenced
this pull request
Oct 23, 2024
Added app_id column to models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
related to this jira ticket
https://snplow.atlassian.net/jira/software/c/projects/PE/boards/50?assignee=712020%3Ab916e641-2c6f-4de9-82f6-d175e2e15bee&selectedIssue=PE-6692
the app_id currently exists in some of the models in the dataset but has been requested to be added to end models.
To do this alterations needed to be made to models yaml files and integration tests.
The model passes the integration tests and my local testing which I conducted with the snowflake biz1_db prod amotic streaming events. (as this is where we keep the snowplow docs2 data which is the only live data that is applicable to this model
Checklist