Add mobile screen engagement calculation using the screen summary context (close #16) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matus-tomlein
force-pushed
the
issue/mobile_screen_engagement
branch
from
9d7f97e to
7a812e4
Compare
rlh1994
suggested changes
Jan 3, 2024
integration_tests/data/expected/snowplow_unified_views_mobile_screen_engagement_expected.csv
Outdated
Show resolved
Hide resolved
integration_tests/models/source/default/snowplow_unified_screen_summary_context_stg.sql
Outdated
Show resolved
Hide resolved
models/views/scratch/snowplow_unified_screen_summary_metrics.sql
Outdated
Show resolved
Hide resolved
|
Also can you add a changelog entry, and we'll need to update the docs to reflect this but that's not required to merge this PR. |
matus-tomlein
force-pushed
the
issue/mobile_screen_engagement
branch
from
4f7fc00 to
3b11265
Compare
matus-tomlein
commented
Jan 5, 2024
...ation_tests/models/expected/snowplow_unified_views_mobile_screen_engagement_expected_stg.sql
Show resolved
Hide resolved
rlh1994
approved these changes
Jan 8, 2024
models/sessions/scratch/snowplow_unified_session_screen_summary_metrics.sql
Outdated
Show resolved
Hide resolved
models/views/scratch/snowplow_unified_screen_summary_metrics.sql
Outdated
Show resolved
Hide resolved
rlh1994
approved these changes
Jan 8, 2024
Base automatically changed from
release/snowplow-unified/0.1.3
to
release/snowplow-unified/0.2.0
January 8, 2024 12:28
matus-tomlein
force-pushed
the
issue/mobile_screen_engagement
branch
from
cd06569 to
eeeba0c
Compare
integration_tests/models/actual/snowplow_unified_views_mobile_screen_engagement_actual.sql
Outdated
Show resolved
Hide resolved
matus-tomlein
force-pushed
the
issue/mobile_screen_engagement
branch
from
26309ac to
60112c4
Compare
# Conflicts: # CHANGELOG
…depth scratch tables
…our of absolute_time_in_s in sessions and users table
…doc_width and doc_height
matus-tomlein
force-pushed
the
issue/mobile_screen_engagement
branch
from
60112c4 to
0928227
Compare
matus-tomlein
merged commit 7c817a4
into
release/snowplow-unified/0.2.0
4 checks passed
agnessnowplow
pushed a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #16
This makes use of the information in the
screen_summarycontext entity to calculate mobile app engagement. The new schemas that this builds on are in review: snowplow/iglu-central#1358The following columns in the
viewstable were updated/added:engaged_time_in_sforeground_sec.absolute_time_in_sforeground_sec+background_sec.horizontal_pixels_scrolledmax_x_offset.vertical_pixels_scrolledmax_y_offset.horizontal_percentage_scrolledmax_x_offset/content_width* 100.vertical_percentage_scrolledmax_y_offset/content_width* 100.last_list_item_indexlast_item_index.list_items_countitems_count.list_items_percentage_scrolledlast_item_index+ 1) /items_count* 100.New configurations:
snowplow__enable_screen_summary_contextsnowplow__screen_summary_contextWhat type of PR is this?
Checklist
Added tests?
Added to documentation?