Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add com.snowplowanalytics.snowplow/event_specification/jsonschema/1-0-1 #1397

Closed
wants to merge 1 commit into from
Closed

Add com.snowplowanalytics.snowplow/event_specification/jsonschema/1-0-1 #1397

wants to merge 1 commit into from

Conversation

igneel64
Copy link
Contributor

@igneel64 igneel64 commented Mar 27, 2024 •
edited
Loading

Add com.snowplowanalytics.snowplow/event_specification/jsonschema/1-0-1 (close #1396)

@igneel64 igneel64 requested review from cksnp and jbeemster March 27, 2024 15:52
@igneel64 igneel64 mentioned this pull request Mar 27, 2024
Merged
@igneel64 igneel64 requested a review from istreeter March 27, 2024 15:57
cksnp
cksnp approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@cksnp cksnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to remember why I had chosen 254 instead of 256 as the ID's length, and can't. Wondering if it was just a typo that got through. Either way, this looks fine.

@AlexBenny
Copy link
Contributor

Moved to #1395

@AlexBenny AlexBenny closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cksnp cksnp cksnp approved these changes

@istreeter istreeter istreeter approved these changes

@jbeemster jbeemster Awaiting requested review from jbeemster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add com.snowplowanalytics.snowplow/event_specification/jsonschema/1-0-1
4 participants
@igneel64 @AlexBenny @istreeter @cksnp