PDP-1562 Consider all ClientFailures as NotFound in lookupSchemasUntil
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
reviewed
Nov 15, 2024
.../main/scala/com.snowplowanalytics.iglu/client/resolver/registries/Http4sRegistryLookup.scala
Outdated
Show resolved
Hide resolved
istreeter
reviewed
Nov 18, 2024
There was a problem hiding this comment.
This looks good, but we need the same thing again on these registry lookups which is used in the batch transfomer.
istreeter
approved these changes
Nov 19, 2024
benjben
changed the title
ClientFailures as NotFound in the Resolver
benjben
force-pushed
the
PDP-1562_handle_403
branch
from
2b530b6 to
1bfecaf
Compare
benjben
changed the title
ClientFailures as NotFound in the ResolverClientFailures as NotFound in lookupSchemasUntil
benjben
force-pushed
the
PDP-1562_handle_403
branch
from
1bfecaf to
3618290
Compare
istreeter
added a commit
to snowplow-incubator/snowplow-bigquery-loader
that referenced
this pull request
Nov 19, 2024
For this app, the most significant changes are: - common-streams has a big change in how it preserves the order of struct fields: snowplow-incubator/common-streams#213. This should not impact how BigQuery loader works. But I highlight here because of the potential risk if we got something wrong. - iglu-scala-client now treats both 403 and 404 as NotFound when listing a series of schemas from the Iglu repos: snowplow/iglu-scala-client#260
istreeter
added a commit
to snowplow-incubator/snowplow-bigquery-loader
that referenced
this pull request
Nov 19, 2024
For this app, the most significant changes are: - common-streams has a big change in how it preserves the order of struct fields: snowplow-incubator/common-streams#98. This should not impact how BigQuery loader works. But I highlight here because of the potential risk if we got something wrong. - iglu-scala-client now treats both 403 and 404 as NotFound when listing a series of schemas from the Iglu repos: snowplow/iglu-scala-client#260
istreeter
added a commit
to snowplow-incubator/snowplow-bigquery-loader
that referenced
this pull request
Jan 3, 2025
For this app, the most significant changes are: - common-streams has a big change in how it preserves the order of struct fields: snowplow-incubator/common-streams#98. This should not impact how BigQuery loader works. But I highlight here because of the potential risk if we got something wrong. - iglu-scala-client now treats both 403 and 404 as NotFound when listing a series of schemas from the Iglu repos: snowplow/iglu-scala-client#260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.