Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infracost configuration #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add infracost configuration #84

wants to merge 1 commit into from

Conversation

stanch
Copy link
Contributor

@stanch stanch commented Nov 9, 2023

No GCP because many resources are not supported yet

@stanch stanch requested a review from jbeemster November 9, 2023 11:59
@jbeemster
Copy link
Member

Gave it a test-drive @stanch - works really well! I think though it might be useful to perhaps target a more "filled" vars file as enabling destinations drives up the cost quite significantly. For AWS now only the S3 Loaders for bad and enriched are enabled as default so that cost point is a little on the low end.

Copy link
Member

@jbeemster jbeemster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Though would generally want this kind of addition to be done with an issue + commit link like everything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants