Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the AWS quickstart for both iglu_server and pipeline to work in the AWS China regions (cn-north-1) and (cn-northwest-1).
The main changes in the underlying modules are that:
aws-cn
ifcn-
is dedicated in the AWS Region and;The second one is important because when testing this DockerHub pulls pretty well always failed (and it is where we store our container images). To use these modules in AWS China you need to build your own ECR mirror in the same sub-account you intend to run the pipeline and manually upload the
linux/amd64
platform images into ECR.Once that is done set the
private_ecr_registry
variable to something like000000000000.dkr.ecr.cn-north-1.amazonaws.com.cn/
(note: you need to maintain the trailing slash).What loaders work?
Not all loaders work out of the box - specifically:
All other loaders should work just fine!