Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GTMSS preview expired message handling #392

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Jan 23, 2025

PDP-1668

So that only messages with provided preview context can expire. If there is no context, message never expires and is simply passed through.

So that only messages with provided preview context can expire. If there
is no context, message never expires and is simply passed through.
@pondzix pondzix force-pushed the fix/gtmss_preview_expiry branch from 4239acc to 609c6ee Compare January 23, 2025 11:16
@pondzix pondzix requested a review from colmsnowplow January 23, 2025 11:17
Copy link
Collaborator

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pondzix pondzix merged commit 609c6ee into develop Jan 23, 2025
1 check passed
@pondzix pondzix deleted the fix/gtmss_preview_expiry branch January 23, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants