Fix wrong screen entity info assigned for screen end event and in case events are tracked right before screen view (close #673) #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matus-tomlein
changed the title
matus-tomlein
force-pushed
the
issue/673-fix_screen_end
branch
from
247367c to
c9b814a
Compare
matus-tomlein
force-pushed
the
issue/673-fix_screen_end
branch
3 times, most recently
from
b514871 to
41f2a05
Compare
…e events are tracked in parallel (close #673)
matus-tomlein
force-pushed
the
issue/673-fix_screen_end
branch
from
41f2a05 to
6370f29
Compare
mscwilson
approved these changes
Feb 14, 2024
| @@ -333,8 +328,9 @@ class Tracker( | |||
| override fun apply(data: Map<String, Any>) { | |||
| if (screenViewAutotracking) { | |||
| val event = data["event"] as? ScreenView? | |||
| event?.let { event -> | |||
| getScreenState()?.let { state -> | |||
| if (event != null) { | |||
There was a problem hiding this comment.
why did you change this bit?
There was a problem hiding this comment.
It had a slightly different behaviour which I think was unintended – the ?: track(event) part could be executed even in case the previous let block was evaluated but returned null. I think this if-else better reflects what should happen and is a bit more clear.
|
|
||
| Assert.assertEquals(2, numberOfScreenViews) | ||
| val numberOfScreenViews = eventSink.trackedEvents.filter { it.schema == TrackerConstants.SCHEMA_SCREEN_VIEW } |
There was a problem hiding this comment.
nit: strange name for a list, I was expecting an int
There was a problem hiding this comment.
Good catch, fixed now.
| Assert.assertEquals(10.0, screenSummary?.get("foreground_sec")) | ||
| Assert.assertEquals(0.0, screenSummary?.get("background_sec")) | ||
|
|
||
| // should have the screen name of the first screen view | ||
| val screenEndScreen = screenEnd?.entities?.find { it.map["schema"] == TrackerConstants.SCHEMA_SCREEN } |
There was a problem hiding this comment.
I've read the word "screen" so much it doesn't look like a real word anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #673
Due to a bug in how the screen state is updated in the tracker, the screen end event is assigned the wrong information – instead of referring to the previous screen name and ID, it contains information of the subsequent screen.
This bug is not only limited to screen end events but may also appear in case an event is tracked right before a screen view event – the event will be assigned the next screen view instead of the one used when it was tracked.