Send correct install referrer timestamps (close #687) #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscwilson
force-pushed
the
bug/687-installreferrer_timestamps
branch
from
1d0452a to
2ca4b89
Compare
jbeemster
reviewed
Jun 4, 2024
| @@ -44,6 +44,9 @@ object Util { | |||
| return System.currentTimeMillis().toString() | |||
| } | |||
|
|
|||
| /** | |||
| * Converts a timestamp in milliseconds to a DateTime. | |||
| */ | |||
| @JvmStatic | |||
| fun getDateTimeFromTimestamp(timestamp: Long): String { | |||
There was a problem hiding this comment.
Should there be a validation in this function that the timestamp is in fact milliseconds? To ensure this issue doesn't happen again?
There was a problem hiding this comment.
This function is used in two places, the InstallReferrer thing and in Session. So it's called with every event that's tracked. I'd rather not add a validation for now
jbeemster
reviewed
Jun 4, 2024
| "referrerClickTimestamp" to if (referrerClickTimestamp > 0) { Util.getDateTimeFromTimestamp(referrerClickTimestamp) } else { null }, | ||
| "installBeginTimestamp" to if (installBeginTimestamp > 0) { Util.getDateTimeFromTimestamp(installBeginTimestamp) } else { null }, | ||
| "referrerClickTimestamp" to if (referrerClickTimestamp > 0) { Util.getDateTimeFromTimestamp(referrerClickTimestamp * 1000) } else { null }, | ||
| "installBeginTimestamp" to if (installBeginTimestamp > 0) { Util.getDateTimeFromTimestamp(installBeginTimestamp * 1000) } else { null }, |
There was a problem hiding this comment.
Are there any unit tests available to ratify this change?
There was a problem hiding this comment.
We don't have any unit tests for this class. The InstallReferrer library isn't available in the tests, so the install_referrer entity doesn't get added in the ApplicationInstallEvent test either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #687
The Android InstallReferrer library returns timestamps in seconds, but the tracker expects milliseconds. This change fixes it so that the correct timestamp strings are sent.
NB: the CI tests for API 30 are currently failing due to flakiness. This is a known problem and will be addressed in a future PR.