Add new WebView Interface #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplow-tracker/src/main/java/com/snowplowanalytics/core/tracker/TrackerWebViewInterfaceV2.kt
Show resolved
Hide resolved
snowplow-tracker/src/main/java/com/snowplowanalytics/core/tracker/TrackerWebViewInterfaceV2.kt
Outdated
Show resolved
Hide resolved
...src/androidTest/java/com/snowplowanalytics/snowplow/tracker/TrackerWebViewInterfaceV2Test.kt
Outdated
Show resolved
Hide resolved
snowplow-tracker/src/main/java/com/snowplowanalytics/core/tracker/TrackerEvent.kt
Show resolved
Hide resolved
matus-tomlein
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
LGTM! 👍
But can we keep this PR open until we have the WebView and JS tracker parts finalized? It's possible that we will find out that we need something extra and we haven't really tested the integration yet (since we don't have the other parts), so we may need some small changes/adjustments.
...src/androidTest/java/com/snowplowanalytics/snowplow/tracker/TrackerWebViewInterfaceV2Test.kt
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of our upgrade to the Snowplow WebView tracker. It allows the tracking of all web events, including certain base/primitive event properties.
Edit: test
tracksEventWithCorrectTracker()is failing on Github, but it's fine locally 🫥