Refactor xhr error log into function to save space on string

snowplow · Nov 15, 2023 · 7b95fe6 · 7b95fe6
1 parent 943afa6
commit 7b95fe6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/libraries/browser-tracker-core/src/tracker/out_queue.ts b/libraries/browser-tracker-core/src/tracker/out_queue.ts
@@ -214,6 +214,10 @@ export function OutQueueManager(
     });
   };
 
+  const logXhrError = (xhr: XMLHttpRequest) => {
+    LOG.error(`Status ${xhr.status}, will not retry.`);
+  };
+
   /**
    * Send event as POST request right away without going to queue. Used when the request surpasses maxGetBytes or maxPostBytes
    * @param body POST request body
@@ -229,7 +233,7 @@ export function OutQueueManager(
           onRequestSuccess?.(batch);
         } else {
           if (!shouldRetryForStatusCode(xhr.status)) {
-            LOG.error(`Status ${xhr.status}, will not retry.`);
+            logXhrError(xhr);
             tryOnRequestFailure(xhr.status, xhr.statusText, batch);
           }
         }
@@ -258,7 +262,7 @@ export function OutQueueManager(
           executeQueue();
         } else {
           if (!shouldRetryForStatusCode(xhr.status)) {
-            LOG.error(`Status ${xhr.status}, will not retry.`);
+            logXhrError(xhr);
             tryOnRequestFailure(xhr.status, xhr.statusText, batch);
             removeEventsFromQueue(numberToSend);
           }