Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Haption] Partially fix the plugin #4338

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[Haption] Partially fix the plugin #4338

merged 2 commits into from
Dec 12, 2023

Conversation

alxbilger
Copy link
Contributor

CMake now passes with SOFA-NG
Fixed some types and includes due to changes from SOFA-NG

The plugin still does not compile

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger
[Haption] Partially fix the plugin
9e8d5e1 
CMake passes with SOFA-NG
Fix some types and includes due to changes from SOFA-NG

The plugin still does not compile
@alxbilger alxbilger added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Dec 5, 2023
@alxbilger alxbilger mentioned this pull request Dec 5, 2023
Closed
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot added the pr: backport todo This PR will be backported into the release preceeding its milestone. label Dec 8, 2023
@hugtalbot hugtalbot added this to the v23.12 milestone Dec 8, 2023
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 12, 2023
@fredroy fredroy merged commit 877035b into sofa-framework:master Dec 12, 2023
5 checks passed
bakpaul pushed a commit that referenced this pull request Feb 19, 2024
@alxbilger @bakpaul
[Haption] Partially fix the plugin (#4338)
5469837 
* [Haption] Partially fix the plugin

CMake passes with SOFA-NG
Fix some types and includes due to changes from SOFA-NG

The plugin still does not compile

* Add a readme file
@bakpaul bakpaul added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v23.12
Development

Successfully merging this pull request may close these issues.
4 participants
@alxbilger @fredroy @hugtalbot @bakpaul