-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spring] Add fixed weak constraint and examples #4750
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical description with RestShapeFF ? 👮
...onent/SolidMechanics/Spring/src/sofa/component/solidmechanics/spring/FixedWeakConstraint.cpp
Outdated
Show resolved
Hide resolved
… to add inline method to regroup addForce implementations and apply it to RestShapeSpringsFF
… apply it to RestShape
…cialize it inside the RestShapeSpringForcefield
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #11. To unlock the merge button, you must
|
[ci-depends-on] detected during build #12. To unlock the merge button, you must
|
[ci-depends-on] detected during build #13. To unlock the merge button, you must
|
Add a
FixedWeakConstraint
. It is really a simplified version ofRestShapeSpringForcefield
that only fixes points with respect to their rest_shape given one single value of stiffness. I didn't use an inheritance becauseRestShapeSpringForcefield
does too much and the two set of features aren't really compatible. Keep it simple...This completes the holy trinity of fixed constraints, now we will have Weak, Projective and Langrangian fixed constraints. It unifies the mechanism.
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/312]
[ci-depends-on https://github.com/SofaDefrost/STLIB/pull/127]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/160]
[ci-depends-on https://github.com/SofaDefrost/Cosserat/pull/148]
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/146]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.Inverse/pull/47]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.DesignOptimization/pull/3]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if