Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newest axios version #197

Closed

Conversation

Agreon
Copy link

@Agreon Agreon commented May 4, 2022

closes #159

@mindhells
Copy link
Member

could you please explain the purpose of this PR?
I don't understand how changing a dev dependency here solves the issue reported in #159
Why changing toBe for toEqual for primitive values?

@Tohaker
Copy link

Tohaker commented May 24, 2022

The new version of axios contains updated types that are incompatible with the current version of this package - if anyone wants to use a recent version of axios, they can't use this package. Merging this PR will solve the linked issue no question.

The tests changing is another story, probably one for another PR/discussion

@mindhells
Copy link
Member

@Tohaker

The new version of axios contains updated types that are incompatible with the current version of this package - if anyone wants to use a recent version of axios, they can't use this package. Merging this PR will solve the linked issue no question.

The tests changing is another story, probably one for another PR/discussion

Are you actually able to reproduce the problem described in #159, because I'm not.
If I create a basic TS sample with the latest versions of each library it just works, no problem with the types.

  • "axios": "0.27.2",
  • "axios-retry": "3.2.5"

Maybe I'm missing something, can you @Tohaker point exactly where is the problem with the types that makes this PR necessary?

@Tohaker
Copy link

Tohaker commented May 25, 2022

I'm not too sure why it works on a new project - upgrading the package versions from a simple wrapper around an axios client generates the exact same error as the issue states; It claims the types are incompatible (yet have the same names)

I'll look closer at it tomorrow, perhaps I spoke a little too soon 😆

@Tohaker
Copy link

Tohaker commented May 26, 2022

Ok my bad - it was a monorepo resolution error

@mindhells mindhells closed this Jun 28, 2022
@mindhells
Copy link
Member

closing for inactivity but thanks anyway

@amalmohann-dgnl
Copy link

@Tohaker how did you resolved the monorepo?

@Tohaker
Copy link

Tohaker commented Jan 15, 2025

Sorry, this was 2.5 years ago so I can't remember at all what I did (probably a lesson to me to explain better in the future!)
My best guess is that deleting node_modules and package-lock.json and reinstalling would help if you're still facing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument of type 'AxiosInstance' is not assignable to parameter of type 'AxiosStatic | AxiosInstance'
4 participants