Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native crate support #54

Closed
wants to merge 6 commits into from
Closed

Native crate support #54

wants to merge 6 commits into from

Conversation

brainstorm
Copy link

@brainstorm brainstorm commented Feb 2, 2020

Fixes issue #53, where an old LLVM/clang version was preventing rust-htslib crate from compiling inside the docker container.

Might affect other bindgen crates in the future so it is worth having llvm-config et al present on $PATH and reasonably up to date, imho.

Perhaps that clang version should be updated accordingly upstream on lambci container itself as well?

…. even if the important bit is just whether it compiles or not
@brainstorm brainstorm requested a review from softprops February 2, 2020 10:51
@brainstorm
Copy link
Author

@softprops, after reading this, I wonder if we shall add this to the Dockerfile:

rustup target add x86_64-unknown-linux-musl

And then on /usr/local/bin/build.sh pass that same --target accordingly?

@softprops
Copy link
Owner

sorry for the delay. I'll try to take a closer look into this with in the coming week.

@brainstorm
Copy link
Author

Yay, thanks @softprops! Looking forward to have this merged in :)

@brainstorm
Copy link
Author

👋

@softprops
Copy link
Owner

Sorry for the delay on this. There's actually a proposal that might help for custom dependency needs #6

@brainstorm
Copy link
Author

Oh yeah, that one looks neat! OTOH, my PR is really just including clang in the mix, that's a pretty common base requirement I reckon? :-S

@brainstorm
Copy link
Author

brainstorm commented Aug 31, 2020

Noticed the alinux2 docker container switch... perhaps clang is installed by default in Amazon Linux 2?

@brainstorm
Copy link
Author

brainstorm commented Sep 1, 2020

I understand the point made in #53 (divergence from upstream lambda environment/image)... OTOH, a quite rust-official docker container that cannot compile *-sys (C bindgen/native) crates can be a bit disappointing DX.

That being said, let me refresh this branch a bit, there might be a more acceptable workaround than pulling in more deps than strictly necessary. If that works I can close this PR with some peace of mind about this ;)

@brainstorm
Copy link
Author

Coincidentally that native rust crate requires docker to build (because cross and MUSL), so the level of inception would get a bit too ridiculous when combined with this builder XD

And now I understand what you mean, this is only meant to be a runtime environment, not a build-time env, closing.

@brainstorm brainstorm closed this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants