Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release action #15

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Add release action #15

merged 5 commits into from
Aug 13, 2024

Conversation

ddoktorski
Copy link
Contributor

Closes #3

Test run in my fork repository


jobs:
verify-branch:
name: Verify that runs on the main branch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It looks that running taiki-e/create-gh-release always creates a release tag from the default branch, as it uses gh release create, here is the exact line. The only exception occurs if the tag for the intended release already exists. The point is that I decided to add this check to prevent a situation where running this workflow on a branch other than main would build assets from this branch but create a release tag from the latest commit on the main branch. While this introduces some limitations, I think it's better to have this explicitly highlighted here.

Base automatically changed from setup-ci to main August 8, 2024 11:57
@ddoktorski ddoktorski merged commit aa0971e into main Aug 13, 2024
5 checks passed
@ddoktorski ddoktorski deleted the release-action branch August 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releasing
3 participants